Update 'rake install' to correctly install build dependencies on adho… - #4525
Merged
Conversation
Member
There was a problem hiding this comment.
doesn't hurt to be safe, but I am curious if there is there an environment with rack_env?(:development) && CDO.chef_managed ? If not this could be simplified.
Member
There was a problem hiding this comment.
Never mind, I see you're just extracting and augmenting existing logic.
Member
|
LGTM |
Contributor
Author
|
One more small change: I added this line for the linux install: |
philbogle
added a commit
that referenced
this pull request
Oct 13, 2015
Update 'rake install' to correctly install build dependencies on adho…
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Update 'rake install' so that it treats adhoc like development in terms of installing build dependencies.
(This is more general version of some previous changes.)