Skip to content

add syntax and runtime error messages for editCode - #4521

Merged
cpirich merged 2 commits into
stagingfrom
editCode_syntax_runtime_errors
Oct 13, 2015
Merged

add syntax and runtime error messages for editCode#4521
cpirich merged 2 commits into
stagingfrom
editCode_syntax_runtime_errors

Conversation

@cpirich

@cpirich cpirich commented Oct 13, 2015

Copy link
Copy Markdown
Contributor

Add unique error messages for runtime and syntax errors that can occur when using editCode / droplet / JSInterpreter

  • For applab, we only show an error message if there is a syntax error. It turns out that applab was fairly broken for the case - browser exceptions would occur repeatedly while we tried to stay in the "Run" state.
  • For playlab, we show error messages for both cases, except for on free play levels (currently level 15 in the hoc2015 script).
  • feedback.js now has a little knowledge of what to do with editCode levels. This can be extended over time and we can tweak the precedence of various error conditions when it comes time to display an error message.

breville
breville reviewed Oct 13, 2015
View reviewed changes
Comment thread apps/i18n/common/en_us.json

@breville breville Oct 13, 2015

Copy link
Copy Markdown
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

previous question about remove vs. fix :)

@breville

breville commented Oct 13, 2015

Copy link
Copy Markdown
Member

lgtm. as discussed, we should look at how the other requiredForSuccess stuff ties into TestResult and whether new values from that should make it up to the server.

cpirich added a commit that referenced this pull request Oct 13, 2015
@cpirich
Merge pull request #4521 from code-dot-org/editCode_syntax_runtime_er…
c977198 
…rors

add syntax and runtime error messages for editCode
@cpirich
cpirich merged commit c977198 into staging Oct 13, 2015
@cpirich
cpirich deleted the editCode_syntax_runtime_errors branch October 13, 2015 20:22
deploy-code-org added a commit that referenced this pull request Oct 13, 2015
@deploy-code-org
Automatically built.
0c5df0c 
commit 5f5ee75
Merge: c977198 705f8a3
Author: davidsbailey <davidsbailey@users.noreply.github.com>
Date:   Tue Oct 13 13:24:11 2015 -0700

    Merge pull request #4526 from code-dot-org/eyes-logging

    improve logging for eyes tests

commit c977198
Merge: 7e7fdd0 b39a489
Author: Chris Pirich <chris@code.org>
Date:   Tue Oct 13 13:22:47 2015 -0700

    Merge pull request #4521 from code-dot-org/editCode_syntax_runtime_errors

    add syntax and runtime error messages for editCode
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

No reviews

Assignees

@breville breville

Labels

None yet

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

2 participants

@cpirich @breville