Skip to content

Revert "Allow projects with non-ascii asset filenames to be remixed" - #4516

Merged
davidsbailey merged 1 commit into
stagingfrom
revert-4481-non-ascii-remix
Oct 13, 2015
Merged

Revert "Allow projects with non-ascii asset filenames to be remixed"#4516
davidsbailey merged 1 commit into
stagingfrom
revert-4481-non-ascii-remix

Conversation

@davidsbailey

@davidsbailey davidsbailey commented Oct 13, 2015

Copy link
Copy Markdown
Member

Reverts #4481

Sorry Josh but it looks like this PR causes assets tests to pass on localhost but fail on test. Reverting for now to unblock the pipeline. Here is the build failure output:

ubuntu@test:~/test/shared$ rake test
Run options: --seed 13884

# Running:

............................................................................................E.

Finished in 11.581719s, 8.1162 runs/s, 84.2707 assertions/s.

  1) Error:
AssetsTest#test_assets_copy_all:
Aws::S3::Errors::SignatureDoesNotMatch: The request signature we calculated does not match the signature you provided. Check your key and signing method.
    /var/lib/gems/2.0.0/gems/aws-sdk-core-2.1.21/lib/seahorse/client/plugins/raise_response_errors.rb:15:in `call'
    /var/lib/gems/2.0.0/gems/aws-sdk-core-2.1.21/lib/aws-sdk-core/plugins/s3_sse_cpk.rb:18:in `call'
    /var/lib/gems/2.0.0/gems/aws-sdk-core-2.1.21/lib/aws-sdk-core/plugins/param_converter.rb:21:in `call'
    /var/lib/gems/2.0.0/gems/aws-sdk-core-2.1.21/lib/seahorse/client/plugins/response_target.rb:21:in `call'
    /var/lib/gems/2.0.0/gems/aws-sdk-core-2.1.21/lib/seahorse/client/request.rb:70:in `send_request'
    /var/lib/gems/2.0.0/gems/aws-sdk-core-2.1.21/lib/seahorse/client/base.rb:207:in `block (2 levels) in define_operation_methods'
    /home/ubuntu/test/shared/middleware/helpers/bucket_helper.rb:70:in `replace_abuse_score'
    /home/ubuntu/test/shared/middleware/files_api.rb:154:in `block (2 levels) in <class:FilesApi>'
    /home/ubuntu/test/shared/middleware/files_api.rb:152:in `each'
    /home/ubuntu/test/shared/middleware/files_api.rb:152:in `block in <class:FilesApi>'
    /var/lib/gems/2.0.0/gems/sinatra-1.4.6/lib/sinatra/base.rb:1609:in `call'
    /var/lib/gems/2.0.0/gems/sinatra-1.4.6/lib/sinatra/base.rb:1609:in `block in compile!'
    /var/lib/gems/2.0.0/gems/sinatra-1.4.6/lib/sinatra/base.rb:974:in `[]'
    /var/lib/gems/2.0.0/gems/sinatra-1.4.6/lib/sinatra/base.rb:974:in `block (3 levels) in route!'
    /var/lib/gems/2.0.0/gems/sinatra-1.4.6/lib/sinatra/base.rb:993:in `route_eval'
    /var/lib/gems/2.0.0/gems/sinatra-1.4.6/lib/sinatra/base.rb:974:in `block (2 levels) in route!'
    /var/lib/gems/2.0.0/gems/sinatra-1.4.6/lib/sinatra/base.rb:1014:in `block in process_route'
    /var/lib/gems/2.0.0/gems/sinatra-1.4.6/lib/sinatra/base.rb:1012:in `catch'
    /var/lib/gems/2.0.0/gems/sinatra-1.4.6/lib/sinatra/base.rb:1012:in `process_route'
    /var/lib/gems/2.0.0/gems/sinatra-1.4.6/lib/sinatra/base.rb:972:in `block in route!'
    /var/lib/gems/2.0.0/gems/sinatra-1.4.6/lib/sinatra/base.rb:971:in `each'
    /var/lib/gems/2.0.0/gems/sinatra-1.4.6/lib/sinatra/base.rb:971:in `route!'
    /var/lib/gems/2.0.0/gems/sinatra-1.4.6/lib/sinatra/base.rb:1084:in `block in dispatch!'
    /var/lib/gems/2.0.0/gems/sinatra-1.4.6/lib/sinatra/base.rb:1066:in `block in invoke'
    /var/lib/gems/2.0.0/gems/sinatra-1.4.6/lib/sinatra/base.rb:1066:in `catch'
    /var/lib/gems/2.0.0/gems/sinatra-1.4.6/lib/sinatra/base.rb:1066:in `invoke'
    /var/lib/gems/2.0.0/gems/sinatra-1.4.6/lib/sinatra/base.rb:1081:in `dispatch!'
    /var/lib/gems/2.0.0/gems/sinatra-1.4.6/lib/sinatra/base.rb:906:in `block in call!'
    /var/lib/gems/2.0.0/gems/sinatra-1.4.6/lib/sinatra/base.rb:1066:in `block in invoke'
    /var/lib/gems/2.0.0/gems/sinatra-1.4.6/lib/sinatra/base.rb:1066:in `catch'
    /var/lib/gems/2.0.0/gems/sinatra-1.4.6/lib/sinatra/base.rb:1066:in `invoke'
    /var/lib/gems/2.0.0/gems/sinatra-1.4.6/lib/sinatra/base.rb:906:in `call!'
    /var/lib/gems/2.0.0/gems/sinatra-1.4.6/lib/sinatra/base.rb:894:in `call'
    /var/lib/gems/2.0.0/gems/rack-protection-1.5.3/lib/rack/protection/xss_header.rb:18:in `call'
    /var/lib/gems/2.0.0/gems/rack-protection-1.5.3/lib/rack/protection/path_traversal.rb:16:in `call'
    /var/lib/gems/2.0.0/gems/rack-protection-1.5.3/lib/rack/protection/json_csrf.rb:18:in `call'
    /var/lib/gems/2.0.0/gems/rack-protection-1.5.3/lib/rack/protection/base.rb:49:in `call'
    /var/lib/gems/2.0.0/gems/rack-protection-1.5.3/lib/rack/protection/base.rb:49:in `call'
    /var/lib/gems/2.0.0/gems/rack-protection-1.5.3/lib/rack/protection/frame_options.rb:31:in `call'
    /var/lib/gems/2.0.0/gems/rack-1.6.4/lib/rack/nulllogger.rb:9:in `call'
    /var/lib/gems/2.0.0/gems/rack-1.6.4/lib/rack/head.rb:13:in `call'
    /var/lib/gems/2.0.0/gems/sinatra-1.4.6/lib/sinatra/base.rb:181:in `call'
    /var/lib/gems/2.0.0/gems/sinatra-1.4.6/lib/sinatra/base.rb:2021:in `call'
    /var/lib/gems/2.0.0/gems/sinatra-1.4.6/lib/sinatra/base.rb:1486:in `block in call'
    /var/lib/gems/2.0.0/gems/sinatra-1.4.6/lib/sinatra/base.rb:1795:in `synchronize'
    /var/lib/gems/2.0.0/gems/sinatra-1.4.6/lib/sinatra/base.rb:1486:in `call'
    /var/lib/gems/2.0.0/gems/rack-test-0.6.3/lib/rack/mock_session.rb:30:in `request'
    /var/lib/gems/2.0.0/gems/rack-test-0.6.3/lib/rack/test.rb:244:in `process_request'
    /var/lib/gems/2.0.0/gems/rack-test-0.6.3/lib/rack/test.rb:85:in `patch'
    /home/ubuntu/test/shared/test/test_assets.rb:332:in `patch_abuse'
    /home/ubuntu/test/shared/test/test_assets.rb:188:in `test_assets_copy_all'

94 runs, 976 assertions, 0 failures, 1 errors, 0 skips
rake aborted!
Command failed with status (1): [ruby -I"lib" -I"/var/lib/gems/2.0.0/gems/rake-10.4.2/lib" "/var/lib/gems/2.0.0/gems/rake-10.4.2/lib/rake/rake_test_loader.rb" "test/test*.rb" ]

Tasks: TOP => test
(See full trace by running task with --trace)

davidsbailey added a commit that referenced this pull request Oct 13, 2015
@davidsbailey
Merge pull request #4516 from code-dot-org/revert-4481-non-ascii-remix
754b5a2 
Revert "Allow projects with non-ascii asset filenames to be remixed"
@davidsbailey
davidsbailey merged commit 754b5a2 into staging Oct 13, 2015
@davidsbailey
davidsbailey deleted the revert-4481-non-ascii-remix branch October 13, 2015 15:22
@davidsbailey

davidsbailey commented Oct 13, 2015

Copy link
Copy Markdown
Member Author

Hey @joshlory , it looks like this revert fixed the shared unit tests on the Test machine. I couldn't figure out why quickly, so I just reverted to unblock the pipeline.

deploy-code-org added a commit that referenced this pull request Oct 13, 2015
@deploy-code-org
Automatically built.
93cc953 
commit e7c7487
Merge: 754b5a2 fc1dc32
Author: Trevor Berg <trevor@code.org>
Date:   Tue Oct 13 09:39:53 2015 -0700

    Merge pull request #4272 from code-dot-org/debug

    Add an option to disable debugger from levelbuilder [#fixes 100228590]

commit 754b5a2
Merge: 8c998c9 473a72a
Author: davidsbailey <davidsbailey@users.noreply.github.com>
Date:   Tue Oct 13 08:08:57 2015 -0700

    Merge pull request #4516 from code-dot-org/revert-4481-non-ascii-remix

    Revert "Allow projects with non-ascii asset filenames to be remixed"

commit 473a72a
Author: davidsbailey <davidsbailey@users.noreply.github.com>
Date:   Tue Oct 13 08:06:45 2015 -0700

    Revert "Allow projects with non-ascii asset filenames to be remixed"
@joshlory joshlory mentioned this pull request Oct 14, 2015
Merged
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

No reviews

Assignees

No one assigned

Labels

None yet

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

1 participant

@davidsbailey