Store Video progress in client side cookie - #4512

Looking (will finish on the bus)

LGTM after comments are addressed. The only one of substance concerns when we consider the video seen. I believe its closest to current behavior to consider the video seen as soon as it starts playing, even if the user doesn't click the X.

(Note in the subsequent change that when you migrate cookie state you'll need to merge the client and server state on the client.)

I think current behavior is to consider the video seen as soon as the page
containing the autoplay video is loaded (or more precisely, as soon as the
browser deals with the Set-Cookie in the http response for the page),
whether not the video or dialog itself has loaded.

In practice (other than some edge cases around the js on the page being
broken) this means that noautoplay=1 will work differently (this param is
only used by tests and not by real users). I have no opinion on which
behavior is better (and don't think it matters that much), but you may have
to fix some ui tests if you change it.

On Mon, Oct 12, 2015 at 6:12 PM, philbogle notifications@github.com wrote:

LGTM after comments are addressed. The only one of substance concerns when
we consider the video seen. I believe its closest to current behavior to
consider the video seen as soon as it starts playing, even if the user
doesn't click the X.

(Note in the subsequent change that when you migrate cookie state you'll
need to merge the client and server state on the client.)

—
Reply to this email directly or view it on GitHub
#4512 (comment)
.