logged in under 13 cant acccess applab shares or /view - #4468
Merged
Conversation
Bjvanminnen
force-pushed
the
under13Applab
branch
from
October 9, 2015 20:55
8c8ff24 to
52a8e16
Compare
Contributor
|
LGTM |
Bjvanminnen
force-pushed
the
under13Applab
branch
from
October 13, 2015 00:14
52a8e16 to
74d18d1
Compare
Bjvanminnen
added a commit
that referenced
this pull request
Oct 13, 2015
logged in under 13 cant acccess applab shares or /view
deploy-code-org
added a commit
that referenced
this pull request
Oct 13, 2015
commit 5cb0308 Merge: d1a3140 7ff9cb2 Author: davidsbailey <davidsbailey@users.noreply.github.com> Date: Tue Oct 13 07:21:54 2015 -0700 Merge pull request #4464 from code-dot-org/design-mode-viz separate design mode content out of divApplab commit 7ff9cb2 Author: David Bailey <dsb123@gmail.com> Date: Mon Oct 12 17:33:41 2015 -0700 fix dimming regression. add tests. commit d1a3140 Merge: 89530d2 bd42943 Author: Bjvanminnen <Bjvanminnen@gmail.com> Date: Mon Oct 12 17:30:49 2015 -0700 Merge pull request #4470 from code-dot-org/appsGitIgnore move apps .gitignore contents into root commit 89530d2 Merge: b9f6b17 74d18d1 Author: Bjvanminnen <Bjvanminnen@gmail.com> Date: Mon Oct 12 17:27:43 2015 -0700 Merge pull request #4468 from code-dot-org/under13Applab logged in under 13 cant acccess applab shares or /view commit b9f6b17 Author: Tanya Parker <tanyacparker@gmail.com> Date: Mon Oct 12 17:22:39 2015 -0700 update artist.feature to remove unnecessary space in error message commit 74d18d1 Author: Brent Van Minnen <bjvanminnen@gmail.com> Date: Fri Oct 9 12:32:30 2015 -0700 logged in under 13 cant acccess applab shares or /view commit f410bca Merge: 07ba0a0 abd05cf Author: Caley Brock <caleybrock7@gmail.com> Date: Mon Oct 12 17:07:33 2015 -0700 Merge pull request #4510 from code-dot-org/promote-pages Link state fact pages to code.org/promote page commit 07ba0a0 Author: Continuous Integration <dev@code.org> Date: Mon Oct 12 23:51:51 2015 +0000 Automatically built. commit d3ccd84 Author: Tanya Parker <tanyacparker@gmail.com> Date: Mon Oct 12 16:47:17 2015 -0700 Updated apps strings commit d3ccd84 Author: Tanya Parker <tanyacparker@gmail.com> Date: Mon Oct 12 16:47:17 2015 -0700 Updated apps strings commit 4346cb4 Merge: 2498416 e8a7d34 Author: Caley Brock <caleybrock7@gmail.com> Date: Mon Oct 12 16:37:25 2015 -0700 Merge pull request #4509 from code-dot-org/reviews Move review special events to teacher-dashboard
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
This is a precursor for some work I'm going to do dealing with asking non-signed in users their age when they go to an applab share page.
Right now we block you from /edit if you're signed in and under 13. This makes it so that also happens if you go to /view or the share page. If you're not signed in, nothing is different.