Add 'StrictHostKeyChecking no' to ssh config for ec2.internal hosts - #4431

Hmm, I just tried this recipe and it didn't update /home/ubuntu/.ssh/config as expected. In fact that file, doesn't match the old version of this file either. Which file is actually updated by the ssh_config.erb?

the cdo-users cookbook applies updates for our list of Chef users on gateway instance. e.g. will@gateway.code.org:/home/will/.ssh/config will be updated by this cookbook change.

For the frontend instances, it looks like the ubuntu@frontend:/home/ubuntu/.ssh/config file is managed only by the cdo-github-access cookbook. Specifically, it seems that the node['cdo-github-access']['config'] Chef attribute contains the contents of the .ssh/config file for these instances. We currently override this attribute on the baseline role, here is what the knife command displays:

will@gateway:~$ knife role show baseline -a override_attributes.cdo-github-access.config
baseline:
  override_attributes.cdo-github-access.config: Host github.com
    StrictHostKeyChecking no

Updating this override attribute through knife or the Chef management console should do the trick for updating the frontend ssh configs.

I updated the attribute as Will suggested and this now deploys correctly on production-daemon.

Let's go ahead and check this in for the nodes where it does apply; will have Josh review.

I don't have a good way to validate this change, but LGTM if it applies correctly on production-daemon.

Yes, tested that this works as expected.