add the Regional Partner Playbook page to our eyes tests - #33706
Merged
Conversation
islemaster
approved these changes
Mar 18, 2020
islemaster
left a comment
islemaster
left a comment
Contributor
There was a problem hiding this comment.
Yeah, page views 3 seems fine. I wonder if there's a better way to organize these so there's no question in the future.
Contributor
Author
|
My general opinion is that anytime you're naming things by adding an incrementing suffix, there's probably a better way to organize them |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Follow-up to #33670
Adding this specifically as an eyes test, because the problem we had was with trying to use a feature (apps i18n) in a part of our system that doesn't support something that feature depends on (blockly), which means it's a prime candidate for an integration test.
Adding it specifically as an eyes rather than a UI test, because this feature often gets overlooked in general so I'd like to elevate our awareness of it.
I'm not 100% sure that the "initial page views 3" feature is precisely the right place to add this; super open to input on that.
Reviewer Checklist: