Skip to content

Add regional partner playbook unit test - #33704

Merged
Hamms merged 3 commits into
stagingfrom
add-RegionalPartnerPlaybook-unit-test
Mar 18, 2020
Merged

Add regional partner playbook unit test#33704
Hamms merged 3 commits into
stagingfrom
add-RegionalPartnerPlaybook-unit-test

Conversation

@Hamms

@Hamms Hamms commented Mar 18, 2020

Copy link
Copy Markdown
Contributor

Originally intended as a follow-up to #33670 to provide a test that would catch this in the future, but I only realized after the test was written that it actually wouldn't catch the issue because blockly is available in our test environment. 🙃

Adding it anyway because unit tests are good, will add an eyes test in a follow-up PR.

Reviewer Checklist:

  • Tests provide adequate coverage
  • Code is well-commented
  • New features are translatable or updates will not break translations
  • Relevant documentation has been added or updated
  • User impact is well-understood and desirable
  • Pull Request is labeled appropriately
  • Follow-up work items (including potential tech debt) are tracked and linked

@Hamms
Hamms requested review from islemaster and jmkulwik March 18, 2020 17:46

@islemaster islemaster left a comment

Copy link
Copy Markdown
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

👍 🚀

@Hamms
Hamms merged commit de4d96c into staging Mar 18, 2020
@Hamms
Hamms deleted the add-RegionalPartnerPlaybook-unit-test branch March 18, 2020 22:15
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants