Prevented localized elements from being imported into non-localized regional partner playbook - #33670
Merged
Merged
Conversation
islemaster
approved these changes
Mar 17, 2020
islemaster
left a comment
islemaster
left a comment
Contributor
There was a problem hiding this comment.
👍 Looks good!
This looks like a really sharp edge. Let's do some brainstorming tomorrow on how we can prevent similar issues in the future.
Contributor
|
I'd be down to be a part of that brainstorming; this sharp edge appears to be caused by our i18n engine, after all. |
This was referenced Mar 18, 2020
7 tasks
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Short Description: The regional partner playbook is unable to load if any localized elements are required in its dependencies. playbook.js imports the redux store. When the 'projects' reducer (which has an un-needed dependency on a localized element) was added to the redux store, it caused the regional partner playbook to fail to load. This PR removes those localized elements.
Long Description: This is a fix for a bug caused by this PR: #33593
Specifically, the addition of the "projects" reducers to the redux store:
code-dot-org/apps/src/code-studio/redux.js
Line 30 in 094f1d2
The "projects" reducers imported from a constants file that used localized elements. This caused problems downstream in a page that explicitly does not import localized elements, https://code.org/educate/regional-partner/playbook
Having these localized elements caused the Regional Partner Virtual Playbook to fail to load due to a JS error.
Removing these localized elements from the constants file fixes this issue.
Links
Testing story
Reviewer Checklist: