Skip to content

Your school: show the special announcement - #27354

Merged
breville merged 1 commit into
stagingfrom
your-school-show-special-announcement-for-pl-2019
Mar 4, 2019
Merged

Your school: show the special announcement#27354
breville merged 1 commit into
stagingfrom
your-school-show-special-announcement-for-pl-2019

Conversation

@breville

@breville breville commented Mar 4, 2019

Copy link
Copy Markdown
Member

The current announcement, which is the PL 2019 trophy for nominations, needs some CSS to make its sparkles work.

screenshot 2019-03-04 12 18 55

The current announcement, which is the PL 2019 trophy for nominations, needs some CSS to make its sparkles work.
@breville
breville requested review from a user, hacodeorg and islemaster March 4, 2019 20:19

@ghost ghost left a comment

Copy link
Copy Markdown

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

approved - only looking at the UI/content, not at the code. will this continue showing up if/when we switch from nominate to another "teacher applications are open" announcement? or will we need to remember to update this page as well when we do that?

@breville

breville commented Mar 4, 2019

Copy link
Copy Markdown
Member Author

@boatmarina Good question. Currently it will vanish when we switch the global "special announcement" to another one. If we want it to stay, we should split it out into its own announcement at that time.

@islemaster islemaster left a comment

Copy link
Copy Markdown
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

@breville
breville merged commit 5c68c8d into staging Mar 4, 2019
@breville
breville deleted the your-school-show-special-announcement-for-pl-2019 branch March 4, 2019 21:41
@breville breville mentioned this pull request Jun 1, 2022
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants