use relative reference for FontAwesome webfont urls - #16458
Merged
Conversation
davidsbailey
approved these changes
Jul 18, 2017
davidsbailey
left a comment
davidsbailey
left a comment
Member
There was a problem hiding this comment.
Nice find, Will! I had noticed the relative offset, but couldn't convince myself that could be the problem.
Contributor
|
Is this something we should ship soon to fix the live-site issue? |
wjordan
added a commit
that referenced
this pull request
Jul 21, 2017
modify additional files, followup to #16458.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Since #16039 (inline
style-min.cssdirectly into page HTML), relative references within the CSS are breaking if the reference resolves differently from the original CSS file's location compared to the HTML page's location.For example, CSS inlined into https://code.org/educate/resources/videos will not resolve
../fonts/fontawesome-webfont.woffcorrectly to/fonts/fontawesome-webfont.woff.