don't use style_min on any inherited site layouts - #16443
Merged
Conversation
any inherited site may use its own style sets.
tanyaparker
approved these changes
Jul 17, 2017
tanyaparker
left a comment
tanyaparker
left a comment
Contributor
There was a problem hiding this comment.
Thanks, Will! You're the best. I'll try to budget in some tech debt time soon to put in tests for our partner sites.
Contributor
Author
|
For partner-site UI test, #16282 could probably be extended to include some minimal partner-site regression-coverage relatively easily. |
Member
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Followup to #16148. The previous fix added a special case for csedweek.org, but did not cover other partner sites that also inherited styles from code.org, leaving partner-sites such as ro.code.org/learn with the same issue.
This change skips
style_minfor any inherited virtual-site configuration that's not the basecode.orgsite, so they can use their own different style-sets without issue.