Show warning banner and disable NewRelic errors for old IE - #16189
Merged
Conversation
Member
|
fyi @tanyaparker |
breville
approved these changes
Jun 30, 2017
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
This PR fixes two issues:
The underlying problem is that old-IE browsers throw load errors on webpack-bundled JS, so our unsupported-browser code is never executed correctly in these environments.
This PR refreshes our (unsupported) old-IE browser code so the warning-banner is properly shown and NewRelic error tracking is disabled (tested on IE 7+8).
I've moved the old-IE code into a separate view, and shifted order of operations around to the following sequence:
theme_common_head_beforeandtheme_common_head_after; PR Manually instrument NewRelic browser monitoring bundle #16158 will explicitly add this in the futurerespond.jsneeds to appear after all CSS, and the NewRelic-error filter needs to appear after NewRelic JS)addEventListener, which needs to come after old-IE polyfills)