inline style-min.css - #16039
Merged
Merged
Conversation
refactor duplicated combine_css logic into page helper.
breville
reviewed
Jun 29, 2017
| %link{rel:'stylesheet', type:'text/css', href:'/style-min.css'} | ||
| =inline_css 'style-min.css' | ||
| -else | ||
| %link{rel:'stylesheet', type:'text/css', href:'/style.css'} |
Member
There was a problem hiding this comment.
we should still use style.css if we're on csedweek.org too. I'll prep a PR to fix.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Followup to #15790 and #15988. This PR refactors duplicated css-bundling logic from
style.cssandstyle-min.cssinto acombine_csspage helper, and uses this to inlinestyle-min.csswhere applicable.This PR should not be merged until after #16031 which reduces the total size of
style-min.csssubstantially (because it removes the font CSS from the bundle).