Inline css - #15988
Merged
Merged
Conversation
Merged
Contributor
Author
|
This PR ended up causing some unit-test flakiness which I'm looking into and will have a fix for soon. |
wjordan
added a commit
that referenced
this pull request
Jun 22, 2017
fixes bug in #15988 causing test-flakiness.
Contributor
|
Worth reverting while we understand the issue, vs. fixing forward? |
Contributor
Author
|
already understood + fixed in #16040. |
ewjordan
pushed a commit
that referenced
this pull request
Jun 29, 2017
fixes bug in #15988 causing test-flakiness.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
This PR adds an
inline_cssmethod to a Pegasus helper, and uses it to inline various small, externally-referenced.cssfiles directly into the HTML response.In many cases, there's a performance benefit to inlining render-blocking CSS directly into
<style>elements within HTML response. Google PageSpeed recommends Optimizing CSS Delivery. However, in many cases we would still prefer external.cssfiles over inline:cssHAML blocks for readability purposes (and to simplify linting/syntax highlighting of the external files). This approach keeps the best of both worlds, allowing us to inline critical CSS while keeping CSS code in separate files for development, allowing minimal diff to our existing codebase.To keep an eye on the overall size of inlined CSS in our pages, I've included a
development-only warning that will produce errors when the gzip-compressed size of all inlined CSS exceeds a threshold (currently 10 kbytes).