Conversation
c3e410e to
10a6619
Compare
10a6619 to
50d4ea9
Compare
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Discovered in #925
Tests run each time we change something in the code while
mix phx.serveris running. This is not really our work flow and hasn't been like this since docker times, so this PR simply removes themix_test_watchdependency.To explain why this suddenly started happening.
We had it as a dependency, but in the move to Phoenix 1.3, I also performed a migration to Elixir 1.4
One of the new features of 1.4 is that we no longer need to explicitly specify an
applications: []list parameter, to specify which applications need to run alongside the main application. Instead, this is inferred from the dependency list.Prior to the move, we did specify a list explicitly, and
mix_test_watchwasn't in it, so it didn't run. Basically, we had an external dependency which we weren't using.In the migration PR, I removed this list, so now it's being inferred, so now
mix_test_watchruns. Since this was an unused dependency before the move, the "fix" is to explicitly remove it.