Conversation
begedin
force-pushed
the
rewrite-controller-tests-to-use-string-ids-as-ember
branch
from
16aa272 to
051aa46
Compare
begedin
force-pushed
the
rewrite-controller-tests-to-use-string-ids-as-ember
branch
from
051aa46 to
81866b5
Compare
joshsmith
previously approved these changes
Sep 19, 2017
joshsmith
force-pushed
the
rewrite-controller-tests-to-use-string-ids-as-ember
branch
from
81866b5 to
dfa21f9
Compare
joshsmith
previously approved these changes
Sep 19, 2017
… sends This reveals a bug in the comment controller, which is now fixed.
joshsmith
force-pushed
the
rewrite-controller-tests-to-use-string-ids-as-ember
branch
from
dfa21f9 to
c0a8d71
Compare
joshsmith
approved these changes
Sep 19, 2017
joshsmith
deleted the
rewrite-controller-tests-to-use-string-ids-as-ember
branch
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
This PR modifies the test JSON Payload helper to create relationships with keys cast to strings, to match the behavior our Ember client uses.
This change reveals a bug in the comment controller, so the PR also fixes that bug, by adding the
IdsToIntegersplug into the controller pipeline. It's unfortunate that this needs to be done on a case-by-case basis right now, but once we get away from ja_resource completely, we can move that plug, as well asDataToAttributes, into a router pipeline.Merging this PR will likely reveal bugs in several other open PRs.