Cleaned up ProjectController, introduced Project.Query#934
Merged
Conversation
begedin
force-pushed
the
cleanup-project-controller-add-project-query
branch
from
a628d9c to
935a415
Compare
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
I approved and merged #933 because the changed seemed perfectly fine (and they were), while the tests were passing.
However, post-merge, I got a couple of compiler warnings and realized the merge introduced a bug due to different ordering of
ProjectControlleractions. The test that was supposed to fail was passing due to missing a key assertion.In order to resolve it in a clean way, I rewrote the test, then proceeded to collapse the multiple function clauses in the controller into one and extracted data loading for the actions into a
Project.Querymodule, which follows a similar approach to the one I'm implementing with tasks in #805