Closed
Conversation
begedin
reviewed
Apr 27, 2017
web/router.ex
Outdated
| post "/webhooks/stripe/connect", StripeConnectEventsController, :create | ||
| post "/webhooks/stripe/platform", StripePlatformEventsController, :create | ||
| post "/webhooks/github_issues", GithubIssueController, :create | ||
| post "/webhooks/github_issue_comments", GithubIssueCommentController, :create |
Contributor
There was a problem hiding this comment.
How do you feel about calling these actions :handle. I feel :create is a bit misleading here.
Contributor
Author
There was a problem hiding this comment.
Yeah I think that makes sense 👍
begedin
force-pushed
the
np-github-webhooks
branch
from
09a0349 to
5662033
Compare
Contributor
|
@npendery We did a lot of stuff since this was submitted, and we ended up implementing basic handling for several issue webhooks as part of a different PR, as we were figuring out the major stuff. I'm sorry about that, but your work here is still appreciated. Simply put, we needed some webhook to figure out the process and this one was relatively straightforward compared to others. |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
What's in this PR?
Adding webhooks to connect to GitHub
References
Progress on: #786