Skip to content

Deprecate $timeout argument for await*() functions #59

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
SimonFrings merged 1 commit into from
Oct 18, 2021
Merged

Deprecate $timeout argument for await*() functions #59

SimonFrings merged 1 commit into from
Oct 18, 2021

Conversation

@clue
Copy link
Owner

@clue clue commented Oct 17, 2021

This changeset deprecates the $timeout argument for the await(), awaitAny() and awaitAll() functions. API authors creating promises are expected to provide means to configure a timeout for the promise instead. For more details, see also the timeout() function.

// deprecated
Clue\React\Block\await($promise, $loop, $timeout);
Clue\React\Block\awaitAny($promises, $loop, $timeout);
Clue\React\Block\awaitAll($promises, $loop, $timeout);

// still supported
Clue\React\Block\await($promise, $loop);
Clue\React\Block\awaitAny($promises, $loop);
Clue\React\Block\awaitAll($promises, $loop);

Refs #14/#17

@clue clue added this to the v1.5.0 milestone Oct 17, 2021
@clue clue requested a review from SimonFrings October 17, 2021 17:56
@SimonFrings SimonFrings merged commit 5906e8d into clue:master Oct 18, 2021
@clue clue deleted the deprecate-timeout branch October 18, 2021 09:37
This was referenced Oct 18, 2021
Merged
Merged
@clue clue mentioned this pull request Aug 9, 2022
Merged
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

1 more reviewer

@SimonFrings SimonFrings SimonFrings approved these changes

Reviewers whose approvals may not affect merge requirements

Assignees

No one assigned

Labels

maintenance

Projects

None yet

Milestone

v1.5.0

Development

Successfully merging this pull request may close these issues.

2 participants

@clue @SimonFrings