Skip to content

discovery: Add IONOS Cloud discoverer #1755

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Open
anatheka wants to merge 57 commits into
base: main
Choose a base branch
from
Open

discovery: Add IONOS Cloud discoverer #1755

anatheka wants to merge 57 commits into from

Conversation

@anatheka
Copy link
Member

@anatheka anatheka commented Jul 8, 2025 •
edited
Loading

This PR adds the IONOS Cloud discoverer to gather evidences for Compute, Storage and Network resources.

@anatheka anatheka requested review from lebogg and oxisto as code owners July 8, 2025 11:27
@anatheka anatheka linked an issue Jul 8, 2025 that may be closed by this pull request
discovery: Add IONOS discoverer #1754
Open
@anatheka anatheka self-assigned this Jul 8, 2025
@anatheka anatheka marked this pull request as draft July 8, 2025 11:27
@codecov
Copy link

codecov bot commented Jul 8, 2025 •
edited
Loading

Codecov Report

❌ Patch coverage is 85.39823% with 33 lines in your changes missing coverage. Please review.
✅ Project coverage is 78.47%. Comparing base (2bbde52) to head (30e366d).
⚠️ Report is 16 commits behind head on main.

Files with missing lines Patch % Lines
service/discovery/ionos/compute_discovery.go 77.77% 5 Missing and 5 partials ⚠️
service/discovery/ionos/ionos.go 80.00% 6 Missing and 4 partials ⚠️
service/discovery/ionos/compute_handle.go 89.28% 3 Missing and 3 partials ⚠️
service/discovery/discovery.go 62.50% 2 Missing and 1 partial ⚠️
service/discovery/ionos/account_discovery.go 85.71% 1 Missing and 1 partial ⚠️
service/discovery/ionos/account_handle.go 88.23% 1 Missing and 1 partial ⚠️
Additional details and impacted files 
@@            Coverage Diff             @@
##             main    #1755      +/-   ##
==========================================
- Coverage   78.49%   78.47%   -0.02%     
==========================================
  Files         147      155       +8     
  Lines       12255     9600    -2655     
==========================================
- Hits         9619     7534    -2085     
+ Misses       2260     1676     -584     
- Partials      376      390      +14
Flag Coverage Δ
unittests 78.47% <85.39%> (-0.02%) ⬇️

Flags with carried forward coverage won't be shown. Click here to find out more.

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

🚀 New features to boost your workflow:
  • ❄️ Test Analytics: Detect flaky tests, report on failures, and find test suite problems.

@anatheka anatheka marked this pull request as ready for review July 24, 2025 12:00
@anatheka anatheka marked this pull request as draft July 24, 2025 12:00
@anatheka anatheka marked this pull request as ready for review October 16, 2025 13:20
lebogg
lebogg reviewed Nov 13, 2025
View reviewed changes
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

@lebogg lebogg lebogg left review comments

@oxisto oxisto Awaiting requested review from oxisto oxisto is a code owner

At least 1 approving review is required to merge this pull request.

Assignees

@anatheka anatheka

Labels

api internal service/discovery

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

discovery: Add IONOS discoverer

3 participants

@anatheka @lebogg