Allow parameters with zero values.#12
Merged
TalLevAmi merged 4 commits intocloudinary:masterfrom Dec 5, 2013
Rade333:master
Merged
Allow parameters with zero values.#12TalLevAmi merged 4 commits intocloudinary:masterfrom Rade333:master
TalLevAmi merged 4 commits intocloudinary:masterfrom
Rade333:master
Conversation
added 4 commits
December 4, 2013 13:46
…s. Fixed some typos.
TalLevAmi
pushed a commit
that referenced
this pull request
Dec 5, 2013
Allow parameters with zero values.
3 tasks
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Issue
Parameters with zero values ("0") are evaluated as false and therefore filtered away.
Example
When cropping images using custom coordinates and the crop should be made from the top left corner both X and Y equal 0. If they are filtered away the crop defaults to the center of the image.
Solution
My solution was to create a custom array filter allowing zero values as either an integer (0) or a string ("0").
I also improved the filtering of empty parameters and added test_no_empty_options to test parameters with empty and zero values. Running the test was successful.