Merged
Conversation
Contributor
|
@nitzanj , @michalkcloudinay , tests are failing |
nitzanj
approved these changes
Aug 5, 2020
Contributor
nitzanj
left a comment
nitzanj
left a comment
There was a problem hiding this comment.
@asisayag2 Tests have become a bit unstable but those are nowhere in the vicinity of these changes (master also failed on those a couple of times). All of the tests are green on local runs so it's an issue with the tests, not the code (certainly not this new bit of code in this PR).
I've opened a ticket to fix the tests but this PR is good to go.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Add eval parameter to upload params