Repository navigation
Conversation
Contributor
There was a problem hiding this comment.
🟢 Approval recommended
No active review issues are recorded for the change pinning the Stackdriver Profiler artifact to a versioned URL.
No open issues 🎉
What changed in this PR
Pins the Java buildpack’s Stackdriver Profiler to a versioned artifact to prevent checksum failures and stale-cache reuse caused by the floating latest URL. Dependency-bot support remains a separate follow-up to #1521.
Changes:
- Replaces the floating URL while preserving the existing checksum and artifact contents.
- Uses the resolver-compatible version
0.20261026.0and documents the date-to-semantic-version mapping. - Adds a regression test rejecting dependency URIs containing
/latest/.
| File | Description |
|---|---|
src/java/frameworks/manifest_uris_test.go |
Adds the manifest check for floating /latest/ dependency URIs. |
manifest.yml |
Pins the profiler artifact URL and updates its version label. |
docs/framework-google_stackdriver_profiler.md |
Explains the version mapping and versioned-URL policy. |
Review effort: Balanced
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Part of #1521 (option 2). Does not close it: making the dependency bot handle this entry is a separate change.
The
google-stackdriver-profilerentry pointed athttps://storage.googleapis.com/cloud-profiler/java/latest/profiler_java_agent.tar.gzwith a pinned sha256. Google replaces thelatestcopy without changing the URL, so the sha broke CI whenlatestmoved on 2026-10-27 (fixed by #1520, but it would break again at the next release). The packager also caches downloads by URI, so a stalelatestdownload keeps being reused on a developer machine and gives a false sha mismatch.Changes:
manifest.yml: the entry now uses the versioned artifact.../java/cloud-profiler-java-agent_20261026_RC00.tar.gz. It has the same bytes aslatesttoday (same sha256bd443833...f835), so nothing changes at runtime. The version label0.4.0was made up; Google's version is a date (20261026_RC00), which the version resolver cannot handle (Invalid Semantic Version). The entry now uses0.20261026.0, which isYYYYMMDD_RCnnwritten as0.YYYYMMDD.nn. The default pin0.xis unchanged and still resolves to it.docs/framework-google_stackdriver_profiler.md: a short "Version" section with the mapping.TestManifestDependencyURIsAreNotFloatinginsrc/java/frameworks: fails when a dependencyuriinmanifest.ymlcontains/latest/. It failed before the manifest change on exactly this entry.Verified: the new test, and the
src/java/frameworksunit tests, pass; a cached zip built from this branch containscloud-profiler-java-agent_20261026_RC00.tar.gz; the existing Stackdriver integration test (Docker, cflinuxfs4) passes with that zip. I also ran a stricter version of that test, which is not part of this PR, against the same zip: it passes and the running JVM has-agentpath:...profiler_java_agent.so=-cprof_project_id=....The dependency pipeline still publishes the date version as is, so the next update of this entry is manual until the
buildpacks-ciwatcher produces the0.YYYYMMDD.nnform (follow-up).