Skip to content

Add multi-tech support to Dynatrace OneAgent integration#1094

Merged
pivotal-david-osullivan merged 7 commits intocloudfoundry:mainfrom
arthfl:main
Jan 27, 2025
Merged

Add multi-tech support to Dynatrace OneAgent integration#1094
pivotal-david-osullivan merged 7 commits intocloudfoundry:mainfrom
arthfl:main

Conversation

@arthfl
Copy link
Contributor

@arthfl arthfl commented Nov 8, 2024

This adds handling for a new, optional, property named addtechnologies a user can configure in a CF service which enables them to add additional OneAgent code-modules to a given java-buildpack deployment.
This is required in multi-buildpack and sidecar scenarious to also monitor other technologies besides java.

Also had to refactor the URL sanitization a bit, because it was eating up multiple include parameters which resulted in displaying a faulty log output.

@TimGerlach
Copy link

Hi @anthonydahanne,
Can you or someone from the buildpack team please have a look at this PR. We at SAP urgently require this feature.

@pivotal-david-osullivan
Copy link
Contributor

pivotal-david-osullivan commented Jan 24, 2025

Do you have a real SaaS env to test this with? I did not get that far but testing with the following (albeit invalid) values in addtechnologies results in the below URL, which is missing the previous tech:

      "credentials": {
        "addtechnologies": "node,ruby",
live.dynatrace.com/api/v1/deployment/installer/agent/unix/paas/latest?include=ruby&bitness=64&Api-Token

EDIT: Please disregard, I was using a non-main branch of the fork to test which must be older! LGTM on main. Would you mind adding a note about this enhancement to the docs/ file for Dynatrace? I will then merge and get it in a release

@arthfl
Copy link
Contributor Author

arthfl commented Jan 27, 2025

@pivotal-david-osullivan done :-)

@pivotal-david-osullivan pivotal-david-osullivan merged commit e5c8eb3 into cloudfoundry:main Jan 27, 2025
1 check passed
ramonskie pushed a commit that referenced this pull request Dec 4, 2025
Add multi-tech support to Dynatrace OneAgent integration
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants