Skip to content

Conversation

@pivotal-david-osullivan
Copy link
Contributor

Adds support for multiple version lines of Tomcat (similar to JRE lines), as 9 & 10.1 are current stable lines.

@anthonydahanne
Copy link
Contributor

Tested this change with this simple webapp: https://github.com/Azure-Samples/tomcat10-jakartaee9

When running it with no specific configuration, it deployed it on Tomcat Instance 9.0.87 and while no errors were displayed, it could not display (404 error) the HelloServlet which relies on jakarta while Tomcat 9 does not support jakarta

Then, I repushed with:

---
applications:
- name: tomcat10
  memory: 2G
  random-route: true
  path: target/helloworld.war
  buildpacks:
    - https://github.com/cloudfoundry/java-buildpack.git#tomcat_version_lines

  env:
    JBP_LOG_LEVEL: info
    JBP_CONFIG_SPRING_AUTO_RECONFIGURATION: '{enabled: false}'
    JBP_CONFIG_OPEN_JDK_JRE: '{ jre: { version: 17.+ } }'
    JBP_CONFIG_TOMCAT: '{ tomcat: { version: 10.1.+ }}'

and the servlet could be displayed properly, as I could see Tomcat Instance 10.1.24 was being downloaded and used.

@anthonydahanne
Copy link
Contributor

LGTM

@pivotal-david-osullivan pivotal-david-osullivan merged commit 9064578 into main May 22, 2024
ramonskie pushed a commit that referenced this pull request Dec 4, 2025
Adds support for Tomcat 10.1 alongside 9
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants