Skip to content

Replace ignore-defaults with ignore-base-config CLI arg for Previews - #15152

Merged
petebacondarwin merged 2 commits into
mainfrom
rename-ignore-defaults
Aug 12, 2026
Merged

Replace ignore-defaults with ignore-base-config CLI arg for Previews#15152
petebacondarwin merged 2 commits into
mainfrom
rename-ignore-defaults

Conversation

@GregBrimble

Copy link
Copy Markdown
Contributor

Fixes WC-5693.

[private beta]: Updates the --ignore-defaults flag to --ignore-base-config on wrangler preview commands.

--ignore-base-config now only takes effect on Preview creation, rather than on each deployment, since Preview base configuration is now copy-on-create rather than inherit-on-deploy.


  • Tests
    • Tests included/updated
    • Automated tests not possible - manual testing has been completed as follows:
    • Additional testing not necessary because:
  • Public documentation
    • Cloudflare docs PR(s):
    • Documentation not necessary because: private beta

A picture of a cute animal (not mandatory, but encouraged)

@changeset-bot

changeset-bot Bot commented Aug 12, 2026

Copy link
Copy Markdown

🦋 Changeset detected

Latest commit: d186419

The changes in this PR will be included in the next version bump.

This PR includes changesets to release 5 packages
Name Type
@cloudflare/deploy-helpers Minor
wrangler Minor
@cloudflare/remote-bindings Patch
@cloudflare/vite-plugin Patch
@cloudflare/vitest-pool-workers Patch

Not sure what this means? Click here to learn what changesets are.

Click here if you're a maintainer who wants to add another changeset to this PR

@github-project-automation github-project-automation Bot moved this to Untriaged in workers-sdk Aug 12, 2026
@workers-devprod
workers-devprod requested review from a team and dario-piotrowicz and removed request for a team August 12, 2026 17:48
@workers-devprod

workers-devprod commented Aug 12, 2026

Copy link
Copy Markdown
Contributor

Codeowners approval required for this PR:

  • ✅ @cloudflare/wrangler
Show detailed file reviewers

devin-ai-integration[bot]

This comment was marked as resolved.

@ask-bonk

ask-bonk Bot commented Aug 12, 2026

Copy link
Copy Markdown
Contributor

Both callers are within the same file and updated. No stale callers.

The change is a clean, consistent rename with correct behavioral changes matching the stated intent (copy-on-create). The PreviewRequestOptions type is still used by createPreview. Tests updated appropriately including the assertion that the deployment URL no longer includes the param. No logic bugs, no backward-compat concerns (private beta), no security issues.

LGTM

github run

@github-actions

github-actions Bot commented Aug 12, 2026

Copy link
Copy Markdown
Contributor

✅ All changesets look good

@pkg-pr-new

pkg-pr-new Bot commented Aug 12, 2026

Copy link
Copy Markdown
@cloudflare/autoconfig

npm i https://pkg.pr.new/@cloudflare/autoconfig@15152

@cloudflare/build-output-utils

npm i https://pkg.pr.new/@cloudflare/build-output-utils@15152

@cloudflare/config

npm i https://pkg.pr.new/@cloudflare/config@15152

create-cloudflare

npm i https://pkg.pr.new/create-cloudflare@15152

@cloudflare/deploy-helpers

npm i https://pkg.pr.new/@cloudflare/deploy-helpers@15152

@cloudflare/kv-asset-handler

npm i https://pkg.pr.new/@cloudflare/kv-asset-handler@15152

miniflare

npm i https://pkg.pr.new/miniflare@15152

@cloudflare/pages-functions

npm i https://pkg.pr.new/@cloudflare/pages-functions@15152

@cloudflare/pages-shared

npm i https://pkg.pr.new/@cloudflare/pages-shared@15152

@cloudflare/unenv-preset

npm i https://pkg.pr.new/@cloudflare/unenv-preset@15152

@cloudflare/vite-plugin

npm i https://pkg.pr.new/@cloudflare/vite-plugin@15152

@cloudflare/vitest-pool-workers

npm i https://pkg.pr.new/@cloudflare/vitest-pool-workers@15152

@cloudflare/workers-auth

npm i https://pkg.pr.new/@cloudflare/workers-auth@15152

@cloudflare/workers-editor-shared

npm i https://pkg.pr.new/@cloudflare/workers-editor-shared@15152

@cloudflare/workers-utils

npm i https://pkg.pr.new/@cloudflare/workers-utils@15152

wrangler

npm i https://pkg.pr.new/wrangler@15152

commit: d186419

Co-authored-by: devin-ai-integration[bot] <158243242+devin-ai-integration[bot]@users.noreply.github.com>
@petebacondarwin
petebacondarwin enabled auto-merge (squash) August 12, 2026 20:13

@workers-devprod workers-devprod left a comment

Copy link
Copy Markdown
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Codeowners reviews satisfied

@petebacondarwin
petebacondarwin merged commit f0f2054 into main Aug 12, 2026
70 of 74 checks passed
@petebacondarwin
petebacondarwin deleted the rename-ignore-defaults branch August 12, 2026 20:14
@github-project-automation github-project-automation Bot moved this from Untriaged to Done in workers-sdk Aug 12, 2026
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

Status: Done

Development

Successfully merging this pull request may close these issues.

4 participants