Skip to content

Add automatic update prompts for out-of-date Cloudflare agent skills - #14872

Merged
dario-piotrowicz merged 19 commits into
mainfrom
dario/DEVX-2596/update-skills
Aug 13, 2026
Merged

Add automatic update prompts for out-of-date Cloudflare agent skills#14872
dario-piotrowicz merged 19 commits into
mainfrom
dario/DEVX-2596/update-skills

Conversation

@dario-piotrowicz

Copy link
Copy Markdown
Member

Fixes https://jira.cfdata.org/browse/DEVX-2596

We've somewhat recently implemented some logic in Wrangler to, after running some commands from a specific subset, it checks whether the user has Cloudflare Skills installed and if not it asks users wether they'd want Wrangler to install those skills for them.

This PR takes it a small step further. If the user had Wrangler install the Cloudflare Skills for them, then after running one of those commands, it will now check the local Cloudflare Skills against the ones in the Cloudflare repository. If in the repository there are some changes then it will offer the user to update those for them.


  • Tests
    • Tests included/updated
    • Automated tests not possible - manual testing has been completed as follows:
    • Additional testing not necessary because:
  • Public documentation
    • Cloudflare docs PR(s):
    • Documentation not necessary because: self explanatory UX improvement

A picture of a cute animal (not mandatory, but encouraged)

@changeset-bot

changeset-bot Bot commented Jul 27, 2026

Copy link
Copy Markdown

🦋 Changeset detected

Latest commit: 6ce0fc3

The changes in this PR will be included in the next version bump.

This PR includes changesets to release 3 packages
Name Type
wrangler Minor
@cloudflare/vite-plugin Patch
@cloudflare/vitest-pool-workers Patch

Not sure what this means? Click here to learn what changesets are.

Click here if you're a maintainer who wants to add another changeset to this PR

@github-actions

github-actions Bot commented Jul 27, 2026

Copy link
Copy Markdown
Contributor

✅ All changesets look good

ask-bonk[bot]

This comment was marked as resolved.

@ask-bonk

ask-bonk Bot commented Jul 27, 2026

Copy link
Copy Markdown
Contributor

Review posted successfully to PR #14872.

I reviewed the PR and found one actionable logic bug in runSkillsUpdateFlow: on a partial update failure, installedTreeSha is advanced to the remote SHA, which silently marks the failed agents as up-to-date so they're never re-prompted for that revision — inconsistent with the full-failure path, which does re-prompt. I posted a suggestion to only advance installedTreeSha when all agents succeed.

The config/env-var opt-out plumbing, validation, changeset, and metrics event additions all look correct and consistent with existing patterns.

github run

@pkg-pr-new

pkg-pr-new Bot commented Jul 27, 2026

Copy link
Copy Markdown
@cloudflare/autoconfig

npm i https://pkg.pr.new/@cloudflare/autoconfig@14872

@cloudflare/build-output-utils

npm i https://pkg.pr.new/@cloudflare/build-output-utils@14872

@cloudflare/config

npm i https://pkg.pr.new/@cloudflare/config@14872

create-cloudflare

npm i https://pkg.pr.new/create-cloudflare@14872

@cloudflare/deploy-helpers

npm i https://pkg.pr.new/@cloudflare/deploy-helpers@14872

@cloudflare/kv-asset-handler

npm i https://pkg.pr.new/@cloudflare/kv-asset-handler@14872

miniflare

npm i https://pkg.pr.new/miniflare@14872

@cloudflare/pages-functions

npm i https://pkg.pr.new/@cloudflare/pages-functions@14872

@cloudflare/pages-shared

npm i https://pkg.pr.new/@cloudflare/pages-shared@14872

@cloudflare/unenv-preset

npm i https://pkg.pr.new/@cloudflare/unenv-preset@14872

@cloudflare/vite-plugin

npm i https://pkg.pr.new/@cloudflare/vite-plugin@14872

@cloudflare/vitest-pool-workers

npm i https://pkg.pr.new/@cloudflare/vitest-pool-workers@14872

@cloudflare/workers-auth

npm i https://pkg.pr.new/@cloudflare/workers-auth@14872

@cloudflare/workers-editor-shared

npm i https://pkg.pr.new/@cloudflare/workers-editor-shared@14872

@cloudflare/workers-utils

npm i https://pkg.pr.new/@cloudflare/workers-utils@14872

wrangler

npm i https://pkg.pr.new/wrangler@14872

commit: 6ce0fc3

@dario-piotrowicz
dario-piotrowicz force-pushed the dario/DEVX-2596/update-skills branch 2 times, most recently from 9f8061e to 05e4b46 Compare July 27, 2026 18:19
@dario-piotrowicz
dario-piotrowicz marked this pull request as ready for review July 27, 2026 19:53
@workers-devprod
workers-devprod requested review from a team and edmundhung and removed request for a team July 27, 2026 19:53
@workers-devprod

workers-devprod commented Jul 27, 2026

Copy link
Copy Markdown
Contributor

Codeowners approval required for this PR:

  • @cloudflare/wrangler
Show detailed file reviewers
  • .changeset/skills-update-prompt.md: [@cloudflare/wrangler]
  • packages/workers-utils/src/environment-variables/factory.ts: [@cloudflare/wrangler]
  • packages/workers-utils/src/environment-variables/misc-variables.ts: [@cloudflare/wrangler]
  • packages/wrangler/src/tests/agents-skills-install.test.ts: [@cloudflare/wrangler]
  • packages/wrangler/src/tests/register-yargs-command-skills.test.ts: [@cloudflare/wrangler]
  • packages/wrangler/src/tests/vitest.setup.ts: [@cloudflare/wrangler]
  • packages/wrangler/src/agents-skills-install.ts: [@cloudflare/wrangler]
  • packages/wrangler/src/core/register-yargs-command.ts: [@cloudflare/wrangler]
  • packages/wrangler/src/metrics/send-event.ts: [@cloudflare/wrangler]

devin-ai-integration[bot]

This comment was marked as resolved.

@dario-piotrowicz
dario-piotrowicz force-pushed the dario/DEVX-2596/update-skills branch from 05e4b46 to 8f3af41 Compare July 27, 2026 20:49
devin-ai-integration[bot]

This comment was marked as resolved.

@dario-piotrowicz
dario-piotrowicz force-pushed the dario/DEVX-2596/update-skills branch from 8f3af41 to 96fa94c Compare July 27, 2026 22:00
devin-ai-integration[bot]

This comment was marked as resolved.

@dario-piotrowicz
dario-piotrowicz force-pushed the dario/DEVX-2596/update-skills branch from 96fa94c to bea8684 Compare July 27, 2026 22:22
devin-ai-integration[bot]

This comment was marked as resolved.

@dario-piotrowicz
dario-piotrowicz force-pushed the dario/DEVX-2596/update-skills branch from bea8684 to 362ad6a Compare July 28, 2026 09:22
devin-ai-integration[bot]

This comment was marked as resolved.

@dario-piotrowicz
dario-piotrowicz force-pushed the dario/DEVX-2596/update-skills branch 2 times, most recently from b0e230a to debfecc Compare July 28, 2026 10:31
devin-ai-integration[bot]

This comment was marked as resolved.

@dario-piotrowicz
dario-piotrowicz force-pushed the dario/DEVX-2596/update-skills branch from debfecc to b3f4ea4 Compare July 28, 2026 13:40
devin-ai-integration[bot]

This comment was marked as resolved.

@dario-piotrowicz
dario-piotrowicz force-pushed the dario/DEVX-2596/update-skills branch from b3f4ea4 to 3354b4f Compare July 28, 2026 14:40

@workers-devprod workers-devprod left a comment

Copy link
Copy Markdown
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Codeowners reviews satisfied

@github-project-automation github-project-automation Bot moved this from Untriaged to Approved in workers-sdk Aug 6, 2026
@dario-piotrowicz
dario-piotrowicz force-pushed the dario/DEVX-2596/update-skills branch from 59c2fcd to a969add Compare August 12, 2026 12:22
@workers-devprod

Copy link
Copy Markdown
Contributor

Codeowners approval required for this PR:

  • ✅ @cloudflare/wrangler
Show detailed file reviewers

devin-ai-integration[bot]

This comment was marked as resolved.

devin-ai-integration[bot]

This comment was marked as resolved.

@dario-piotrowicz
dario-piotrowicz merged commit 339509d into main Aug 13, 2026
59 checks passed
@dario-piotrowicz
dario-piotrowicz deleted the dario/DEVX-2596/update-skills branch August 13, 2026 11:03
@github-project-automation github-project-automation Bot moved this from Approved to Done in workers-sdk Aug 13, 2026
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

Status: Done

Development

Successfully merging this pull request may close these issues.

3 participants