breaking change: Remove worker::send entirely #861
+43
−230
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
Ahh, found the failures here - I see this is because of Axum. |
|
Cases like It might not be a great example of usage, but I am using it in my website. |
|
I've updated this PR to use an experimental wasm bindgen feature for this in wasm-bindgen/wasm-bindgen#4770, and this approach seems to work now. |
|
All tests are passing - CI failure here is due to the examples build not using the forked wasm bindgen worker-build. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Mulling this one over as an alternative to #784.
This uses a new wasm bindgen feature for
unsafe-single-threaded-traitswhich just makes everything Sync and Send for us under the single-threaded assumption.Would simplify things not having to have this noise in Rust Workers codebase.