Fix #include in the middle of the file. #5458
Merged
+6
−4
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This isn't supposepd to work. In particular, expanding the include _inside_ a namespace block puts all the symbols into the wrong namespace. However, the fact that this is a C header (wrapped in `extern "C" {`) coincidentally causes the misplaced symbols to end up linking correctly (because it disables complex C++ symbol names, effectively stripping the namespace prefixes). So it ended up working by accident, but we shouldn't rely on that.
…NULL. Just a little thing that bothered me.
|
Added a second tiny drive-by to this because otherwise I was just going to send another PR to the same person. |
anonrig
approved these changes
Nov 4, 2025
This comment was marked as outdated.
This comment was marked as outdated.
danlapid
approved these changes
Nov 4, 2025
|
Thanks! |
jasnell
approved these changes
Nov 5, 2025
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
4 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This isn't supposepd to work. In particular, expanding the include inside a namespace block puts all the symbols into the wrong namespace. However, the fact that this is a C header (wrapped in
extern "C" {) coincidentally causes the misplaced symbols to end up linking correctly (because it disables complex C++ symbol names, effectively stripping the namespace prefixes). So it ended up working by accident, but we shouldn't rely on that.