Add user exception metadata to internal exception #5454
Merged
+76
−0
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
danlapid
force-pushed
the
dlapid/log_exception_to_traces
branch
from
f6dbafb to
516080f
Compare
jasnell
reviewed
Nov 3, 2025
jasnell
reviewed
Nov 3, 2025
jasnell
reviewed
Nov 3, 2025
jasnell
reviewed
Nov 3, 2025
jasnell
reviewed
Nov 3, 2025
jasnell
reviewed
Nov 3, 2025
This comment was marked as outdated.
This comment was marked as outdated.
|
LGTM, but I'll let @jasnell give approval -- he provided a much better review than I could have. :) |
danlapid
force-pushed
the
dlapid/log_exception_to_traces
branch
from
516080f to
2bd513d
Compare
|
Just a rebase |
danlapid
force-pushed
the
dlapid/log_exception_to_traces
branch
2 times, most recently
from
5513c21 to
08b4a3d
Compare
jasnell
approved these changes
Nov 4, 2025
danlapid
force-pushed
the
dlapid/log_exception_to_traces
branch
from
08b4a3d to
acfda65
Compare
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
No description provided.