Skip to content

Add startup exceptions to traces #5453

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
merged 1 commit into from
Nov 4, 2025
Merged

Add startup exceptions to traces #5453

merged 1 commit into from
Nov 4, 2025
+10 −4

Conversation

@danlapid
Copy link
Collaborator

@danlapid danlapid commented Nov 2, 2025

No description provided.

@danlapid danlapid requested review from a team as code owners November 2, 2025 13:55
@github-actions
Copy link

github-actions bot commented Nov 2, 2025 •
edited
Loading

The generated output of @cloudflare/workers-types matches the snapshot in types/generated-snapshot 🎉

fhanau
fhanau approved these changes Nov 2, 2025
View reviewed changes
Copy link
Contributor

@fhanau fhanau left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM, was confused at first since for STW reporting this as an exception would make more sense than creating a span, but as I understand we add a span for the internal tracing system here where this is the right approach.

@danlapid danlapid force-pushed the dlapid/trace_startup_exceptions branch from 27d1035 to a6f1e3c Compare November 4, 2025 11:37
@codspeed-hq
Copy link

codspeed-hq bot commented Nov 4, 2025 •
edited
Loading

CodSpeed Performance Report

Merging #5453 will not alter performance

Comparing dlapid/trace_startup_exceptions (e3b0d83) with main (2376e81)

Summary

✅ 34 untouched
⏩ 9 skipped1

Footnotes

  1. 9 benchmarks were skipped, so the baseline results were used instead. If they were deleted from the codebase, click here and archive them to remove them from the performance reports. ↩

@danlapid danlapid force-pushed the dlapid/trace_startup_exceptions branch from a6f1e3c to 56874a5 Compare November 4, 2025 16:02
@danlapid danlapid enabled auto-merge November 4, 2025 16:03
@danlapid danlapid force-pushed the dlapid/trace_startup_exceptions branch from 56874a5 to e3b0d83 Compare November 4, 2025 17:31
@danlapid danlapid merged commit 2936846 into main Nov 4, 2025
21 checks passed
@danlapid danlapid deleted the dlapid/trace_startup_exceptions branch November 4, 2025 18:02
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

@anonrig anonrig anonrig approved these changes

@fhanau fhanau fhanau approved these changes

Assignees

No one assigned

Labels

None yet

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

3 participants

@danlapid @anonrig @fhanau