[Experimental] Implement writeIntoUint8Array for TextEncoder #5449
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
jasnell
commented
Nov 1, 2025
| "boolean", "true"); | ||
| } | ||
|
|
||
| KJ_TEST("writeIntoUint8Array") { |
There was a problem hiding this comment.
btw, in case it's not obvious, just had claude do the tests.
jasnell
force-pushed
the
jasnell/experiment-textencoder
branch
from
5024f56 to
58b4f3d
Compare
This comment was marked as outdated.
This comment was marked as outdated.
jasnell
force-pushed
the
jasnell/experiment-textencoder
branch
from
58b4f3d to
b3fcc16
Compare
jasnell
force-pushed
the
jasnell/experiment-textencoder
branch
from
b3fcc16 to
94bd37f
Compare
jasnell
force-pushed
the
jasnell/experiment-textencoder
branch
from
94bd37f to
52dd739
Compare
|
Ok, given a bunch of additional testing and evaluation and review from Erik, this is not the direction we want to go.. which is pretty much what I suspected :-) .. closing this! |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This is an experiment for now. Do not merge yet.
Background: When running under high memory pressure, operations like
TextEncoder::encodecan cause additional memory load by flattening the input strings. This is particularly true in React/NextJS SSR during the render phase. The string flattening itself can lead to additional GC thrashing that adds significant additional CPU overhead to the rendering. This PR experiments with detecting when we are in high memory load conditions and using an alternative utf8 encode that avoids the string flattening. It only kicks in under certain conditions (e.g. string isn't already flat, string is over a certain length, memory pressure is over a certain threshold, etc). It's not intended to make encoding faster, it is ended to avoid flattening and the associated GC costs.There's an additional v8 patch included, so this PR is not expected to pass internal CI until the same patch is landed there.