clang-tidy: google-readability-casting, modernize-use-using #5423
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
anonrig
reviewed
Oct 27, 2025
npaun
force-pushed
the
npaun/clang-tidy-casts
branch
from
daae087 to
d775020
Compare
fhanau
reviewed
Oct 28, 2025
|
Certainly on board with using modernize-use-using though. Also see the post I made internally re. coordinating on enabling clang-tidy checks. |
fhanau
approved these changes
Oct 28, 2025
npaun
force-pushed
the
npaun/clang-tidy-casts
branch
from
d775020 to
3ee8898
Compare
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This PR uses clang-tidy to fix two of my pet peeves:
google-readability-casting. We do not need a plethora of ways to cast in our codebase. This change gets rid of C-style casts(T)xand function-style castsT(x). It also gets rid of some exotic stuff like using casting syntax to run a constructor(std::string)y. Now we have to usestatic_cast<T>(x)andreinterpret_cast<T>(x)as appropriate.modernize-use-using. We don't need two different ways to create type aliases. Gets rid oftypedefin favour ofusing.