split actor targets in bazel #5419
Conversation
CodSpeed Performance ReportMerging #5419 will not alter performanceComparing Summary
Footnotes
|
anonrig
force-pushed
the
yagiz/split-actor
branch
2 times, most recently
from
2b66215 to
2273770
Compare
anonrig
force-pushed
the
yagiz/split-actor
branch
from
2273770 to
e98117a
Compare
| hdrs = ["capnp-mock.h"], | ||
| visibility = ["//visibility:public"], | ||
| deps = [ | ||
| "@capnp-cpp//src/capnp:capnp-rpc", |
There was a problem hiding this comment.
hmm, none of the headers of the capnp-rpc are being used by capnp-mock, but some capnp bazel targets are pretty peculiar (getting link errors based on functions being declared in one target but defined in another one, long story that is out of scope here), so if there's a different reason to include this here go ahead.
| implementation_deps = [ | ||
| ":io-gate", | ||
| "//src/workerd/jsg:exception", | ||
| "//src/workerd/util:autogate", |
There was a problem hiding this comment.
nit: "//src/workerd/util:sentry" should also be here
| deps = [ | ||
| ":actor-storage_capnp", | ||
| "//src/workerd/jsg:exception", | ||
| "@capnp-cpp//src/capnp:capnp-rpc", |
There was a problem hiding this comment.
nit: capnp-rpc should not be needed here, we don't include any capnp headers in actor-cache.h
| ], | ||
| }), | ||
| implementation_deps = [ | ||
| ":actor-storage", |
There was a problem hiding this comment.
nit: Line is not needed, actor-storage is only referenced from actor-cache
2 participants
Resolves a todo