-
Notifications
You must be signed in to change notification settings - Fork 465
start working on jsg/rust integration #5378
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
base: main
Are you sure you want to change the base?
Conversation
89d6e2b to
01bc9ec
Compare
This comment has been minimized.
This comment has been minimized.
|
The generated output of Full Type Diff |
f30d328 to
0fc6fee
Compare
| @@ -1,51 +0,0 @@ | |||
| // Copyright (c) 2017-2022 Cloudflare, Inc. | |||
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
FWIW, we shouldn't delete this immediately. Instead, the rust impl should only be enabled using an autogate until it's determined to be stable enough in production.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Yes, this pull request is not ready to land yet
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
This pull-request is not ready to land. It's too early to say if we need an autogate or not. Probably yes, but it's too early right now.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Yes, I know it's still early. Just flagging this now so that it doesn't get forgotten. I'd say that if this does move forward, an autogate will absolutely be necessary when it comes to replacing any existing built-in.
0fc6fee to
f91726a
Compare
f91726a to
f463539
Compare
f463539 to
440508a
Compare
No description provided.