Skip to content

Conversation

@anonrig
Copy link
Member

@anonrig anonrig commented Oct 22, 2025

No description provided.

@anonrig anonrig force-pushed the yagiz/rust-jsg-boilerplate branch from 89d6e2b to 01bc9ec Compare October 22, 2025 20:28
@codspeed-hq

This comment has been minimized.

@github-actions
Copy link

github-actions bot commented Oct 23, 2025

The generated output of @cloudflare/workers-types has been changed by this PR. If this is intentional, run just generate-types to update the snapshot. Alternatively, you can download the full generated types:

Full Type Diff

@anonrig anonrig force-pushed the yagiz/rust-jsg-boilerplate branch from f30d328 to 0fc6fee Compare October 27, 2025 17:47
@@ -1,51 +0,0 @@
// Copyright (c) 2017-2022 Cloudflare, Inc.
Copy link
Collaborator

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

FWIW, we shouldn't delete this immediately. Instead, the rust impl should only be enabled using an autogate until it's determined to be stable enough in production.

Copy link
Member Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Yes, this pull request is not ready to land yet

Copy link
Member Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

This pull-request is not ready to land. It's too early to say if we need an autogate or not. Probably yes, but it's too early right now.

Copy link
Collaborator

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Yes, I know it's still early. Just flagging this now so that it doesn't get forgotten. I'd say that if this does move forward, an autogate will absolutely be necessary when it comes to replacing any existing built-in.

@anonrig anonrig force-pushed the yagiz/rust-jsg-boilerplate branch from 0fc6fee to f91726a Compare October 27, 2025 19:31
@anonrig anonrig force-pushed the yagiz/rust-jsg-boilerplate branch from f91726a to f463539 Compare October 30, 2025 15:09
@anonrig anonrig force-pushed the yagiz/rust-jsg-boilerplate branch from f463539 to 440508a Compare October 30, 2025 20:24
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants