Add a useragent header when fetching data + print response if not JSON #59
+32
−2
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
thibmeu
reviewed
Oct 9, 2025
There was a problem hiding this comment.
overall seems ok.
Minimising the use of defaults would be great.
@AkshataDM should be able to provide a deeper review
AkshatM
requested changes
Oct 9, 2025
This commit introduces two fixes/QoL changes. First off, it adds a useragent to every request sent by this tool. This is required iff the remote server rejects requests without any specific useragent being set (an example for this is Wikimedia Toolforge, which will drop all HTTP requests without a User-Agent header See: https://wikitech.wikimedia.org/wiki/Help:Toolforge/Banned#Banned_user_agents_and_IP_addresses Additionally the second change introduced prints the body of the response into stderr iff the tool encounters a error in parsing the JSON data into JWKS sets. This is particularly useful because it (~~allowed me to debug the error above~~) will help folks figure out exactly what data got sent back from the server and why the tool might not be able to validate the keys.
|
Amazing - thanks for your contribution @sohomdatta1! If this doesn't auto-deploy, I will cut a release early next week. |
AkshatM
added a commit
that referenced
this pull request
Oct 13, 2025
Major change since last release: Add a useragent header when fetching data + print response if not JSON (#59)
AkshatM
added a commit
that referenced
this pull request
Oct 13, 2025
Major change since last release: Add a useragent header when fetching data + print response if not JSON (#59)
AkshatM
added a commit
that referenced
this pull request
Oct 13, 2025
Major change since last release: Add a useragent header when fetching data + print response if not JSON (#59)
AkshatM
added a commit
that referenced
this pull request
Oct 13, 2025
Major change since last release: Add a useragent header when fetching data + print response if not JSON (#59)
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Hi hi,
So, background, I was implementing this protocol on https://github.com/sohomdatta1/link-dispenser (which is a webservice hosted on Wikimedia's community-run Toolforge servers that checks if the external references of/on a page are still web accessible). After implementing the protocol, I was testing the server to make sure I had implemented the directory correctly, and while testing that, I found two small QoL fixes that would be nice to have in this tool! I know the contributing guidelines ask me to create issues, but I decided to open a PR directly since the fixes are relatively minor :)
Basically, this commit introduces two fixes/QoL changes. First off, it adds a useragent to every request sent by this tool. This is required iff the remote server rejects requests without any specific useragent being set (an example for this is Wikimedia Toolforge, which will drop all HTTP requests without a User-Agent header
See: https://wikitech.wikimedia.org/wiki/Help:Toolforge/Banned#Banned_user_agents_and_IP_addresses
Additionally, the second change introduced prints the body of the response into stderr iff the tool encounters an error in parsing the JSON data into JWKS sets. This is particularly useful because it (
allowed me to debug the error above) will help folks figure out exactly what data got sent back from the server and why the tool might not be able to validate the keys.Hope y'all have a nice day!