Skip to content

feat: v4 to v5 migration for zero trust access service token #11

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
merged 1 commit into from
Nov 5, 2025
Merged

feat: v4 to v5 migration for zero trust access service token #11

merged 1 commit into from
Nov 5, 2025
+877 −3

Conversation

@SirCortly
Copy link
Collaborator

@SirCortly SirCortly commented Oct 31, 2025

Adds v4→v5 migration for zero_trust_access_service_token.

Renames deprecated resource type `access_service_token` -> `zero_trust_access_service_token` 

Removes deprecated field `min_days_for_renewal`
Converts field `client_secret_version` from int -> float64

@SirCortly SirCortly requested a review from tamas-jozsa October 31, 2025 17:56
@SirCortly SirCortly force-pushed the cortlyons/migrate-zero-trust-access-service-token branch 4 times, most recently from 167a4bf to a06a4d3 Compare October 31, 2025 21:45
@SirCortly SirCortly marked this pull request as ready for review October 31, 2025 21:47
@SirCortly SirCortly requested a review from a team October 31, 2025 21:50
ssicard
ssicard reviewed Oct 31, 2025
View reviewed changes
@SirCortly SirCortly force-pushed the cortlyons/migrate-zero-trust-access-service-token branch from a06a4d3 to 615c969 Compare November 3, 2025 18:59
ssicard
ssicard reviewed Nov 3, 2025
View reviewed changes
vaishakdinesh
vaishakdinesh reviewed Nov 3, 2025
View reviewed changes
integration/v4_to_v5/testdata/zero_trust_access_service_token/expected/terraform.tfstate
"attributes": {
"account_id": "f037e56e89293a057740de681ac9abbe",
"client_id": "123456.access",
"client_secret": "123456",
Copy link
Member

@vaishakdinesh vaishakdinesh Nov 3, 2025

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Would the client secret exist in the state file?

Copy link
Collaborator Author

@SirCortly SirCortly Nov 3, 2025

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I generated the state file by running a terraform apply on the input .tf file, so I think so, I thought it was a bit strange as well.

@SirCortly SirCortly force-pushed the cortlyons/migrate-zero-trust-access-service-token branch from 615c969 to 3bc6e2f Compare November 3, 2025 21:00
@SirCortly SirCortly force-pushed the cortlyons/migrate-zero-trust-access-service-token branch from 3bc6e2f to a952326 Compare November 3, 2025 22:12
@tamas-jozsa tamas-jozsa merged commit 4943ea0 into main Nov 5, 2025
7 checks passed
@tamas-jozsa tamas-jozsa deleted the cortlyons/migrate-zero-trust-access-service-token branch November 5, 2025 10:56
@vaishakdinesh vaishakdinesh added this to the Phase 1 milestone Nov 5, 2025
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

@ssicard ssicard ssicard left review comments

@vaishakdinesh vaishakdinesh vaishakdinesh left review comments

@tamas-jozsa tamas-jozsa tamas-jozsa approved these changes

Assignees

No one assigned

Labels

None yet

Projects

None yet

Milestone

Phase 1

Development

Successfully merging this pull request may close these issues.

4 participants

@SirCortly @ssicard @tamas-jozsa @vaishakdinesh