feat(zero_trust_access_group): v4 to v5 migration acceptance tests #6564
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Changes being requested
adjustment to zero_trust_access_group migration acceptance tests.
Acceptance test run results
Steps to run acceptance tests
TF_ACC=1 TF_MIGRATE_BINARY_PATH=/Users/rotematzaba/cf-repos/terraform-devstack/tf-migrate/tf-migrate go test -v -run "TestMigrate" ./internal/services/zero_trust_access_group
Test output
=== RUN TestMigrateZeroTrustAccessGroupMultiVersion_Basic
=== RUN TestMigrateZeroTrustAccessGroupMultiVersion_Basic/from_v4_52_1
--- PASS: TestMigrateZeroTrustAccessGroupMultiVersion_Basic (6.38s)
--- PASS: TestMigrateZeroTrustAccessGroupMultiVersion_Basic/from_v4_52_1 (6.38s)
=== RUN TestMigrateZeroTrustAccessGroupMultiVersion_ComplexRules
=== RUN TestMigrateZeroTrustAccessGroupMultiVersion_ComplexRules/from_v4_52_1
--- PASS: TestMigrateZeroTrustAccessGroupMultiVersion_ComplexRules (6.31s)
--- PASS: TestMigrateZeroTrustAccessGroupMultiVersion_ComplexRules/from_v4_52_1 (6.31s)
=== RUN TestMigrateZeroTrustAccessGroupMultiVersion_ZoneScoped
=== RUN TestMigrateZeroTrustAccessGroupMultiVersion_ZoneScoped/from_v4_52_1
--- PASS: TestMigrateZeroTrustAccessGroupMultiVersion_ZoneScoped (6.55s)
--- PASS: TestMigrateZeroTrustAccessGroupMultiVersion_ZoneScoped/from_v4_52_1 (6.55s)
=== RUN TestMigrateZeroTrustAccessGroup_EdgeCases
=== RUN TestMigrateZeroTrustAccessGroup_EdgeCases/v4_single_email
=== RUN TestMigrateZeroTrustAccessGroup_EdgeCases/v4_multiple_emails_and_ips
=== RUN TestMigrateZeroTrustAccessGroup_EdgeCases/v4_all_rule_types
--- PASS: TestMigrateZeroTrustAccessGroup_EdgeCases (18.08s)
--- PASS: TestMigrateZeroTrustAccessGroup_EdgeCases/v4_single_email (5.81s)
--- PASS: TestMigrateZeroTrustAccessGroup_EdgeCases/v4_multiple_emails_and_ips (6.55s)
--- PASS: TestMigrateZeroTrustAccessGroup_EdgeCases/v4_all_rule_types (5.71s)
PASS
ok github.com/cloudflare/terraform-provider-cloudflare/internal/services/zero_trust_access_group 39.317s