Skip to content

fix(kv): handle special characters correctly #6549

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Open
ferhatelmas wants to merge 1 commit into
base: main
Choose a base branch
from
Open

fix(kv): handle special characters correctly #6549

ferhatelmas wants to merge 1 commit into from

Conversation

@ferhatelmas
Copy link
Member

@ferhatelmas ferhatelmas commented Dec 17, 2025 •
edited
Loading

resolves #6542

  • I understand that this repository is auto-generated and my pull request may not be merged

Changes being requested

Save key raw in state and encode whenever needed.

Acceptance test run results

  • I have added or updated acceptance tests for my changes
  • I have run acceptance tests for my changes and included the results below

Steps to run acceptance tests

  • terraform apply
  • terraform apply

Test output

Additional context & links

https://github.com/ferhatelmas/terraform-provider-cloudflare-6542

Apply complete! Resources: 0 added, 0 changed, 0 destroyed.

Outputs:

keys_created = [
  "config/app/name",
  "config/app/version",
  "users/admin/settings",
  "data/nested/deep/key",
]
namespace_id = "d2ad2910501f4cb899022b1d7ac35429"
namespace_title = "terraform-test-namespace"

@ferhatelmas
fix(kv): handle special characters correctly
f837d59 
resolves cloudflare#6542

Signed-off-by: ferhat elmas <elmas.ferhat@gmail.com>
@ferhatelmas ferhatelmas mentioned this pull request Dec 17, 2025
Open
3 tasks
radev
radev approved these changes Dec 17, 2025
View reviewed changes
Copy link

@radev radev left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I would prefer fixing this in generate Go client (by escaping for every customer), but that would be a breaking change, I guess?

@ferhatelmas
Copy link
Member Author

ferhatelmas commented Dec 17, 2025

Yes. Otherwise I would prefer it as well.

@musa-cf
Copy link
Contributor

musa-cf commented Dec 19, 2025

We can upstream this change into the Go SDK to ensure that SDK users have it fixed too. If that gets done, we can close this PR.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

1 more reviewer

@radev radev radev approved these changes

Reviewers whose approvals may not affect merge requirements

At least 2 approving reviews are required to merge this pull request.

Assignees

No one assigned

Labels

None yet

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

cloudflare_workers_kv - Provider produced inconsistent result after apply when key_value contains backslash

3 participants

@ferhatelmas @musa-cf @radev