DRAFT: cloudflare_list import no items #6418
Open
+107
−38
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Changes being requested
Currently we explicitly import any existing list items into the nested items property for cloudflare_list.
This causes the next Terraform plan, for a list with no items set, to think that cloudflare_list.items is going from a set containing items to a null set. Which will cause it to remove all existing items.
Acceptance test run results
All passing for
cloudflare_list.Additional context & links
Unfortunately the Terraform plugin framework doesn't not provide access to the Config or Plan while reading a resource so we cannot conditionally import
itemsThis causes the first plan/apply after an import to recreate the nested items. This causes no change to the resource but will make an actual API call.
This causes the tests that use the import block to fail because they expect a no-op import.