Skip to content

Conversation

@broswen
Copy link
Contributor

@broswen broswen commented Nov 4, 2025

  • I understand that this repository is auto-generated and my pull request may not be merged

Changes being requested

Currently we explicitly import any existing list items into the nested items property for cloudflare_list.

This causes the next Terraform plan, for a list with no items set, to think that cloudflare_list.items is going from a set containing items to a null set. Which will cause it to remove all existing items.

Acceptance test run results

  • I have run acceptance tests for my changes and included the results below

All passing for cloudflare_list.

Additional context & links

Unfortunately the Terraform plugin framework doesn't not provide access to the Config or Plan while reading a resource so we cannot conditionally import items

This causes the first plan/apply after an import to recreate the nested items. This causes no change to the resource but will make an actual API call.

This causes the tests that use the import block to fail because they expect a no-op import.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

1 participant