DS-15400: Update logpull_retention test #6277
Open
+52
−10
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
soheiokamoto
commented
Sep 30, 2025
| Config: testLogpullRetentionSetConfig(rnd, zoneID, true), | ||
| ConfigPlanChecks: resource.ConfigPlanChecks{ | ||
| PreApply: []plancheck.PlanCheck{ | ||
| //plancheck.ExpectResourceAction(resourceName, plancheck.ResourceActionCreate), |
There was a problem hiding this comment.
Commented out plancheck.ExpectResourceAction() for both steps, as I get error like below inconsistently:
go test ./internal/services/logpull_retention -run "^TestAccLogpullRetention" -v -count 1
=== RUN TestAccLogpullRetention_Basic
resource_test.go:28: Step 2/3 error: Pre-apply plan check(s) failed:
'cloudflare_logpull_retention.mgvohhbmfy' - expected Create, got action(s): [delete create]
--- FAIL: TestAccLogpullRetention_Basic (7.11s)
FAIL
FAIL github.com/cloudflare/terraform-provider-cloudflare/internal/services/logpull_retention 7.114s
FAIL
logpull_retention is based on a single flag / state per zone (and not multiple resources), so the state / action may be different based on initial state (before running the test).
stainless-app
bot
force-pushed
the
next
branch
from
49bbfc7 to
618db3c
Compare
stainless-app
bot
force-pushed
the
next
branch
from
44843f0 to
057b6a7
Compare
soheiokamoto
force-pushed
the
sohei/DS-15400-update-logpull-retention-test
branch
from
5863dba to
fa5d0ea
Compare
stainless-app
bot
force-pushed
the
next
branch
from
122740e to
81ae3c0
Compare
This updates `logpull_retention` test: 1. Add import test. 2. Switch to Plan and State Checks from legacy Checks. Test passes locally: ``` go test ./internal/services/logpull_retention -run "^TestAccLogpullRetention" -v -count 1 === RUN TestAccLogpullRetention_Basic --- PASS: TestAccLogpullRetention_Basic (10.48s) PASS ok github.com/cloudflare/terraform-provider-cloudflare/internal/services/logpull_retention 10.487s ```
soheiokamoto
force-pushed
the
sohei/DS-15400-update-logpull-retention-test
branch
from
fa5d0ea to
efaf862
Compare
|
Rebased. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This updates
logpull_retentiontest:Test passes locally: