fix queue consumer id population #6181
Open
+587
−4
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
jkoe-cf
force-pushed
the
jkoe/fix-queue-consumer-id
branch
2 times, most recently
from
fbc8e13 to
4b2e794
Compare
vaishakdinesh
requested review from
mgirouard,
musa-cf,
tamas-jozsa and
vaishakdinesh
| type QueueConsumerDataSourceModel struct { | ||
| AccountID types.String `tfsdk:"account_id" path:"account_id,required"` | ||
| ConsumerID types.String `tfsdk:"consumer_id" path:"consumer_id,required"` | ||
| ConsumerID types.String `tfsdk:"consumer_id" json:"consumer_id,computed"` |
There was a problem hiding this comment.
Need to check why this is needed @musa-cf @mgirouard
|
This fix should resolve the issue #5652 |
| return nil | ||
| } | ||
|
|
||
| func testAccCheckCloudflareQueueConsumerBasic(rnd, accountID, queueName string) string { |
There was a problem hiding this comment.
Can this be added as files under testdata ? Same for the below files.
There was a problem hiding this comment.
Refactored it into files, let me know if it looks ok?
…te consumer response
jkoe-cf
force-pushed
the
jkoe/fix-queue-consumer-id
branch
from
ddcdf39 to
b2f5f67
Compare
jkoe-cf
force-pushed
the
jkoe/fix-queue-consumer-id
branch
from
b2f5f67 to
cfb03d0
Compare
|
When will this be merged? This is a pretty nasty bug and no real workaround for it. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
5 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Changes being requested
Updating queue consumer_id to be computed because it is generated during the create queue consumer API call
Additional context & links