metrics: only log recurring WouldBlock errors. #2231
+16
−1
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
toidiu
force-pushed
the
akothari/would_block
branch
3 times, most recently
from
581bbad to
6bd60b9
Compare
toidiu
force-pushed
the
akothari/would_block
branch
from
6bd60b9 to
425b2ea
Compare
| // We would like to measure WouldBlock errors that result because | ||
| // of the hot `loop`ing calls to `sendmsg`. | ||
| if recurring_would_block { | ||
| would_block_metric.inc(); |
There was a problem hiding this comment.
I think that send_to_wouldblock_duration_s_count gives you this... I guess only once in cases where the same connection hits this connection multiple times in a loop. Do we care about the difference?
antoniovicente
approved these changes
Nov 3, 2025
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
No description provided.