Permalink
Comparing changes
Choose two branches to see what’s changed or to start a new pull request.
If you need to, you can also or
learn more about diff comparisons.
Open a pull request
Create a new pull request by comparing changes across two branches. If you need to, you can also .
Learn more about diff comparisons here.
...
- 3 commits
- 5 files changed
- 1 contributor
Commits on Oct 4, 2024
Commits on Nov 1, 2024
-
fix(certificaterequest): ignore empty issuer group
A CertificateRequest's reference to an Issuer can have an empty Group, which we were considering as equivalent to matching, then later rejecting the CertificateRequest when it was for an unknown issuer. While setting the group is optional in the schema, our documentation has always included the group in the issuer reference. The rejection was racing with other controllers, including the built-in controllers, and preventing them from issuing certificates. This changeset updates CertificateRequestController to ignore CertificateRequests where the issuer group is unset, preventing the race with controllers for other issuers. We'll continue to reject CertificateRequests for unknown kinds if the group matches our group. Bug: #149 Fixes: d8c1b77 ("feat: add ClusterOriginIssuer")
-
Loading
This comparison is taking too long to generate.
Unfortunately it looks like we can’t render this comparison for you right now. It might be too big, or there might be something weird with your repository.
You can try running this command locally to see the comparison on your machine:
git diff v0.10.0...v0.11.0