Avoid out-of-bounds panics #65
Open
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Zotyamester
reviewed
Mar 15, 2025
| { | ||
| let state = self.state.lock(); | ||
| if self.index < state.objects.len() { | ||
| if self.index < state.objects.len() - 1 { |
There was a problem hiding this comment.
I believe rearranging the inequality like if self.index + 1 < state.objects.len() { could be safer in most cases, considering that state.objects.len() can return 0.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
The logic here allows situations where the access to
state.objectswill be out of bounds. This PR just makes the obvious fix to keepstate.indexin-bounds.