-
Notifications
You must be signed in to change notification settings - Fork 683
CUSTOM_ORIGIN_SERVER Adding custom_origin_server to CustomHostname st… #316
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Conversation
|
Thanks for the PR @oh4real. I'm not seeing this field in the public API documentation. If you're seeing this in a response, are you able to raise a support ticket to get the documentation updated and confirm this is something that is intended to be used by the end users? |
|
It's complicated. And no, like many, many things, is not in api.cloudflare.com It's in the SSL for SAAS (Enterprise) docs: https://developers.cloudflare.com/ssl/ssl-for-saas/hostname-specific/hostname-specific/ This is publicly accessible, even though only available to Enterprise configured zones. Also, if you are enterprise, when you go to create a custom host via the Admin console, it is an option: I have submitted a ticket to support for them to add this the enterprise feature to the API docs. Also, we've been using the property/feature for almost a year with our in-house cloudflare client. |
|
Appreciate the context. We've got this enabled on our Enterprise account and see what you've mentioned above. The main caveat here we need to look out for is that if it's not documented, we don't really have a leg to stand on if something is changed unexpectedly. This isn't something the Cloudflare folks generally do but it's a good practice not to rely on anything that isn't publicly documented to avoid random breakages. Keep us posted on the ticket status and if you hit any issues, we can ping some Cloudflare folks to either advise or take a look at getting some eyes on it. |
|
I got a response from the support team. Un/fortunately, the request has gone into an internal ticketing system for the API team, so I have no visibility on when/if the property/feature will ever make it into the official API. They closed the ticket, so I don't think I should expect any updates to it. I am open to suggestions on how to proceed? |
|
@oh4real it looks like the documentation for this has been updated. If you can fix up the minor formatting issues here, we can look to get this one merged. |
Co-Authored-By: Jacob Bednarz <jacob.bednarz@gmail.com>
Co-Authored-By: Jacob Bednarz <jacob.bednarz@gmail.com>
|
I missed your note on docs. I've updated per your formatting suggestions. Hopefully, branch is good. |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
This LGTM 👏 @patryk any concerns with this one?
|
Thanks for contribution @oh4real and my apologies for the delay in response. |
cloudflare#316) * CUSTOM_ORIGIN_SERVER Adding custom_origin_server to CustomHostname struct * Update custom_hostname_test.go Co-Authored-By: Jacob Bednarz <jacob.bednarz@gmail.com> * Update custom_hostname_test.go Co-Authored-By: Jacob Bednarz <jacob.bednarz@gmail.com> * CUSTOM_ORIGIN_SERVER Not sure how json got so ugly
|
Hello, this is no longer available on the v6 branch, which is very unfortunate! |

…ruct
Description
I added an optional custom_origin_server property to the CustomHostname struct so the cloudflare-go client can be used to create this special custom hostname.
Has your change been tested?
I added a new test for the optional property.
go testran successfully.Screenshots (if appropriate):
Types of changes
What sort of change does your code introduce/modify?
Checklist:
??? If https://godoc.org/github.com/cloudflare/cloudflare-go#CustomHostname is auto-generated, then it should show up. If not, instructions would be helpful.