add catalog models to Prettierignore, add back streaming examples for deepseek and fable#31365
add catalog models to Prettierignore, add back streaming examples for deepseek and fable#31365ethulia wants to merge 3 commits into
Conversation
ethulia
requested review from
a team,
kathayl,
mattrothenberg,
mchenco,
palashgo,
roerohan,
superhighfives and
zeke
as code owners
Review✅ No style-guide issues found in commit CommandsOnly codeowners can run commands. Post a comment with the command to trigger it.
|
github-actions
Bot
assigned
kathayl,
mattrothenberg,
mchenco,
palashgo,
roerohan,
superhighfives,
thebongy and
zeke
|
This pull request requires reviews from CODEOWNERS as it changes files that match the following patterns:
|
![ask-bonk[bot]](https://avatars.githubusercontent.com/in/2454580?s=60&v=4){kind=small}
There was a problem hiding this comment.
The streaming examples added back for deepseek and fable contain captured runner failures ( objects) instead of successful responses. These should be fixed or removed before merge. Also, the PR body is empty — please add a brief description of why these examples were removed and what changed.
| ], | ||
| "stream": true | ||
| }, | ||
| "error": { |
There was a problem hiding this comment.
This streaming example contains a captured runner failure ( object). Examples should contain successful or data, not an internal error. Please recapture with a working response or remove this example.
| "model": "deepseek/deepseek-v4-pro", | ||
| "stream": true | ||
| }, | ||
| "error": { |
There was a problem hiding this comment.
This streaming example contains a captured runner failure ( object). Examples should contain successful or data, not an internal error. Please recapture with a working response or remove this example.
|
Review posted on PR #31365. I applied labels: Summary of changes
Issues flagged HIGH — The two streaming examples contain captured runner failures instead of successful responses:
The LOW — The PR body is essentially empty (default template with no filled-in context). A brief description explaining why the streaming examples were previously removed and what prompted adding them back would help reviewers. |
|
Preview URL: https://190bef22.preview.developers.cloudflare.com |
10 participants
Summary
Screenshots (optional)
Documentation checklist