fix(flue): parse single-package Dependabot PR bodies#31363
Conversation
Grouped Dependabot PRs include a markdown table; single-package PRs use prose on the first line: "Bumps [name](url) from X to Y." The parser only matched the table format, so single-package PRs (e.g. major version bumps like vite 7→8) returned an empty package list and the workflow exited early without posting a review comment. Add a prose fallback that runs when the table regex finds nothing.
Review⏸️ Automatic reviews for this PR are paused. This PR has already received 2 automatic reviews. To run another review, a codeowner can comment
|
|
This pull request requires reviews from CODEOWNERS as it changes files that match the following patterns:
|
ask-bonk
Bot
added
bug
![ask-bonk[bot]](https://avatars.githubusercontent.com/in/2454580?s=60&v=4){kind=small}
There was a problem hiding this comment.
Summary: Adds a prose-regex fallback to so single-package Dependabot PRs (including all major-version bumps) are correctly parsed. Previously only the grouped-PR markdown table format was matched, causing the workflow to exit early on single-package PRs.
Assessment: No issues found. Clean, targeted fix with appropriate JSDoc updates.
Labels applied: ,
There was a problem hiding this comment.
Summary: Adds a prose-regex fallback to parseDependabotPackages() so single-package Dependabot PRs (including all major-version bumps) are correctly parsed. Previously only the grouped-PR markdown table format was matched, causing the workflow to exit early on single-package PRs.
Assessment: No issues found. Clean, targeted fix with appropriate JSDoc updates.
Labels applied: bug, engineering
|
I've reviewed PR #31363. What changed: Added a prose-regex fallback in Labels applied: Assessment: No issues found. The fix is minimal and targeted, the JSDoc is updated to document both formats, and the change is consistent with the existing code style. No inline suggestions were needed. I've posted an approving review on the PR. |
|
Preview URL: https://f303de6c.preview.developers.cloudflare.com |
|
/review |
2 participants
What
Adds a prose fallback to
parseDependabotPackages()in the flue dependabot-review workflow.Why
Grouped Dependabot PRs include a markdown table that the parser already handles:
Single-package PRs (including all major-version bumps, which Dependabot never groups) use prose instead:
The parser only matched the table format, so single-package PRs returned an empty list and the workflow exited early at the
packages.length === 0guard without posting a review comment. This is why the bot ran on #31359 (grouped, 9 packages) but not #31357 (vite 7→8, single-package major bump).Fix
When the table regex finds nothing, fall back to matching the prose format. The grouped path is unchanged.