Update setInnerContent syntax in html-rewriter.mdx #26237
+1
−3
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
`<code>` doesn't seem to work over multiple lines broken during a reformatting refactor?
nelsonjchen
requested review from
a team,
GregBrimble,
WalshyDev,
irvinebroque,
kodster28,
korinne and
mikenomitch
as code owners
github-actions
bot
added
November 2025
product:workers
github-actions
bot
assigned
GregBrimble,
irvinebroque,
kodster28,
korinne,
mikenomitch and
WalshyDev
There was a problem hiding this comment.
Pull Request Overview
This PR improves the formatting of the setInnerContent method documentation in the HTML Rewriter API reference by replacing a multi-line <code> block with a cleaner inline code format.
- Simplified the markdown formatting for the
setInnerContentmethod signature
💡 Add Copilot custom instructions for smarter, more guided reviews. Learn how to get started.
| - <code> | ||
| setInnerContent(contentContent, contentOptionsContentOptionsoptional) | ||
| </code> | ||
| - `setInnerContent(contentContent, contentOptionsContentOptionsoptional)` |
There was a problem hiding this comment.
The parameter names appear to have duplicated words. 'contentContent' should likely be 'content' and 'contentOptionsContentOptionsoptional' should likely be 'contentOptions' (optional).
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
7 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Summary
<code>doesn't seem to work over multiple linesbroken during a reformatting refactor?
933987a#diff-fa5863d597bafb036dee58cc25456f938afcf47db163e9ce658b76fb040b136cR173
Screenshots (optional)
Documentation checklist